Skip to content

fix: fixed preload resource reuse issues and devtool hmr shared #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix: fixed preload resource reuse issues and devtool hmr shared #2580

merged 3 commits into from
Jun 5, 2024

Conversation

zhoushaw
Copy link
Collaborator

@zhoushaw zhoushaw commented Jun 5, 2024 •
edited
Loading

Description

  • fix: devtools Adjustments hmr changes the behavior of shared to make changes more stable
  • fix: In load remote, link preload is not used to preload resources, preventing resource reloading

Related Issue

#2569

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9457a1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@module-federation/devtools Patch
runtime-remote1 Patch
@module-federation/runtime Patch
@module-federation/sdk Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/runtime-tools Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/dts-plugin Patch
@module-federation/enhanced Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/rspack Patch
@module-federation/utilities Patch
node-dynamic-remote-new-version Patch
node-dynamic-remote Patch
3008-runtime-remote Patch
@module-federation/modernjs Patch
@module-federation/third-party-dts-extractor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Jun 5, 2024 •
edited
Loading

✅ Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 9457a1e
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/66600168f477050008524753
😎 Deploy Preview https://deploy-preview-2580--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhoushaw zhoushaw merged commit a2bfb9b into main Jun 5, 2024
13 checks passed
@zhoushaw zhoushaw deleted the fix/load-remote-preload-logic branch June 5, 2024 07:02
@vovkvlad vovkvlad mentioned this pull request Jun 5, 2024
Closed
5 tasks
@2heal1 2heal1 mentioned this pull request Jun 11, 2024
Merged
@hagushorn hagushorn mentioned this pull request Jan 14, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2heal1 2heal1 2heal1 approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhoushaw @2heal1